Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

docs(readme): add pylint limitations #246

Merged
merged 4 commits into from
Oct 14, 2021
Merged

Conversation

danielcressman
Copy link
Contributor

Re: googleapis/google-cloud-python#11865, the generated methods on the ImageAnnotatorClient class do not play nicely with Pylint. As a workaround, let's add this to the README so that future users have a chance to see this limitation up-front and save themselves some time.

Helps users work around googleapis/google-cloud-python#11865 🦕

@danielcressman danielcressman requested a review from a team as a code owner October 6, 2021 06:20
@product-auto-label product-auto-label bot added the api: vision Issues related to the googleapis/python-vision API. label Oct 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2021
Re: https://github.com/googleapis/python-vision/issues/6, the generated methods on the `ImageAnnotatorClient` class do not play nicely with Pylint.
As a workaround, let's add this to the README so that future users have a chance to see this limitation up-front and save themselves some time.
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @danielcressman!

@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@danielcressman danielcressman changed the title Call out Pylint limitations in README docs: call out pylint limitations in readme Oct 7, 2021
@danielcressman
Copy link
Contributor Author

@busunkim96 I'm not familiar with the merge flow here, and I can't tell when/if the checks that it's waiting for will run. Is there something that I need to do to get those to run? Or is it just a matter of waiting for them to automatically happen?

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 12, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 12, 2021
@parthea parthea changed the title docs: call out pylint limitations in readme docs(readme): add pylint limitations Oct 14, 2021
@parthea parthea merged commit e4fb61f into googleapis:main Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: vision Issues related to the googleapis/python-vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants